From: Ian Campbell Date: Thu, 3 Apr 2014 08:59:41 +0000 (+0100) Subject: xen: arm: consolidate body of flush_xen_data_tlb_range_va_local X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~5299 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=67a126eabdedb5aba5da0945104d176ac3ce0946;p=xen.git xen: arm: consolidate body of flush_xen_data_tlb_range_va_local This is almost identical on both sub architectures. Signed-off-by: Ian Campbell Acked-by: Julien Grall [ ijc -- fixed coding style ] --- diff --git a/xen/include/asm-arm/arm32/page.h b/xen/include/asm-arm/arm32/page.h index b0a2025d2b..d839d03fbb 100644 --- a/xen/include/asm-arm/arm32/page.h +++ b/xen/include/asm-arm/arm32/page.h @@ -63,23 +63,10 @@ static inline void flush_xen_data_tlb_local(void) : : "r" (r0) /* dummy */: "memory"); } -/* - * Flush a range of VA's hypervisor mappings from the data TLB of the - * local processor. This is not sufficient when changing code mappings - * or for self modifying code. - */ -static inline void flush_xen_data_tlb_range_va_local(unsigned long va, - unsigned long size) +/* Flush TLB of local processor for address va. */ +static inline void __flush_xen_data_tlb_one_local(vaddr_t va) { - unsigned long end = va + size; - dsb(sy); /* Ensure preceding are visible */ - while ( va < end ) { - asm volatile(STORE_CP32(0, TLBIMVAH) - : : "r" (va) : "memory"); - va += PAGE_SIZE; - } - dsb(sy); /* Ensure completion of the TLB flush */ - isb(); + asm volatile(STORE_CP32(0, TLBIMVAH) : : "r" (va) : "memory"); } /* Ask the MMU to translate a VA for us */ diff --git a/xen/include/asm-arm/arm64/page.h b/xen/include/asm-arm/arm64/page.h index 65332a3a6d..897d79b0c4 100644 --- a/xen/include/asm-arm/arm64/page.h +++ b/xen/include/asm-arm/arm64/page.h @@ -55,23 +55,10 @@ static inline void flush_xen_data_tlb_local(void) : : : "memory"); } -/* - * Flush a range of VA's hypervisor mappings from the data TLB of the - * local processor. This is not sufficient when changing code mappings - * or for self modifying code. - */ -static inline void flush_xen_data_tlb_range_va_local(unsigned long va, - unsigned long size) +/* Flush TLB of local processor for address va. */ +static inline void __flush_xen_data_tlb_one_local(vaddr_t va) { - unsigned long end = va + size; - dsb(sy); /* Ensure preceding are visible */ - while ( va < end ) { - asm volatile("tlbi vae2, %0;" - : : "r" (va>>PAGE_SHIFT) : "memory"); - va += PAGE_SIZE; - } - dsb(sy); /* Ensure completion of the TLB flush */ - isb(); + asm volatile("tlbi vae2, %0;" : : "r" (va>>PAGE_SHIFT) : "memory"); } /* Ask the MMU to translate a VA for us */ diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h index d18ec2a7f2..d58ad1deb3 100644 --- a/xen/include/asm-arm/page.h +++ b/xen/include/asm-arm/page.h @@ -306,6 +306,25 @@ static inline void clean_and_invalidate_xen_dcache_va_range : : "r" (_p), "m" (*_p)); \ } while (0) +/* + * Flush a range of VA's hypervisor mappings from the data TLB of the + * local processor. This is not sufficient when changing code mappings + * or for self modifying code. + */ +static inline void flush_xen_data_tlb_range_va_local(unsigned long va, + unsigned long size) +{ + unsigned long end = va + size; + dsb(sy); /* Ensure preceding are visible */ + while ( va < end ) + { + __flush_xen_data_tlb_one_local(va); + va += PAGE_SIZE; + } + dsb(sy); /* Ensure completion of the TLB flush */ + isb(); +} + /* Flush the dcache for an entire page. */ void flush_page_to_ram(unsigned long mfn);